On Wed, Jul 3, 2019 at 1:37 PM Matthias Kaehlcke <m...@chromium.org> wrote: > > Add the 'realtek,eee-led-mode-disable' property to disable EEE > LED mode on Realtek PHYs that support it. > > Signed-off-by: Matthias Kaehlcke <m...@chromium.org> > --- > Changes in v2: > - document 'realtek,eee-led-mode-disable' instead of > 'realtek,enable-ssc' in the initial version > --- > .../devicetree/bindings/net/realtek.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/realtek.txt > > diff --git a/Documentation/devicetree/bindings/net/realtek.txt > b/Documentation/devicetree/bindings/net/realtek.txt > new file mode 100644 > index 000000000000..63f7002fa704 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/realtek.txt > @@ -0,0 +1,19 @@ > +Realtek PHY properties. > + > +This document describes properties of Realtek PHYs. > + > +Optional properties: > +- realtek,eee-led-mode-disable: Disable EEE LED mode on this port. > + > +Example: > + > +mdio0 { > + compatible = "snps,dwmac-mdio"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethphy: ethernet-phy@1 { > + reg = <1>; > + realtek,eee-led-mode-disable;
I think if we're going to have custom properties for phys, we should have a compatible string to at least validate whether the custom properties are even valid for the node. Rob