From: Jesper Dangaard Brouer <bro...@redhat.com> > This code is okay, but I would likely write it as: > > if (rx_q->page_pool) { > page_pool_request_shutdown(rx_q->page_pool)); > page_pool_free(rx_q->page_pool); > } > > Because (as you noticed) page_pool_free() have some API misuse checks, > that will get triggered, and thus provide a warning of you forget to > update this when driver evolves.
Yeah, makes sense. I will update and resend. Thanks for the review!