pci_alloc_consistent calls dma_alloc_coherent directly.
In commit 518a2f1925c3
("dma-mapping: zero memory returned from dma_alloc_*"),
dma_alloc_coherent has already zeroed the memory.
So memset is not needed.

Signed-off-by: Fuqian Huang <huangfq.dax...@gmail.com>
---
Changes in v3:
  - Use actual commit rather than the merge commit in the commit message

 drivers/media/pci/ngene/ngene-core.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/media/pci/ngene/ngene-core.c 
b/drivers/media/pci/ngene/ngene-core.c
index b75ab7d29226..af15ca1c501b 100644
--- a/drivers/media/pci/ngene/ngene-core.c
+++ b/drivers/media/pci/ngene/ngene-core.c
@@ -854,8 +854,6 @@ static int create_ring_buffer(struct pci_dev *pci_dev,
        if (!Head)
                return -ENOMEM;
 
-       memset(Head, 0, MemSize);
-
        PARingBufferCur = PARingBufferHead;
        Cur = Head;
 
@@ -907,8 +905,6 @@ static int AllocateRingBuffers(struct pci_dev *pci_dev,
        if (SCListMem == NULL)
                return -ENOMEM;
 
-       memset(SCListMem, 0, SCListMemSize);
-
        pRingBuffer->SCListMem = SCListMem;
        pRingBuffer->PASCListMem = PASCListMem;
        pRingBuffer->SCListMemSize = SCListMemSize;
-- 
2.11.0

Reply via email to