On 06/25, Song Liu wrote:
>
> This patch allows uprobe to use original page when possible (all uprobes
> on the page are already removed).
I can't review. I do not understand vm enough.
> + if (!is_register) {
> + struct page *orig_page;
> + pgoff_t index;
> +
> + index = vaddr_to_offset(vma, vaddr & PAGE_MASK) >> PAGE_SHIFT;
> + orig_page = find_get_page(vma->vm_file->f_inode->i_mapping,
> + index);
> +
> + if (orig_page) {
> + if (pages_identical(new_page, orig_page)) {
Shouldn't we at least check PageUptodate?
and I am a bit surprised there is no simple way to unmap the old page
in this case...
Oleg.
