Hi Vishal,
On Thu, Jul 11, 2019 at 09:09:37AM +0000, Vishal Sagar wrote:
...
> > > +static int xcsi2rxss_subscribe_event(struct v4l2_subdev *sd,
> > > + struct v4l2_fh *fh,
> > > + struct v4l2_event_subscription *sub)
> > > +{
> > > + struct xcsi2rxss_state *xcsi2rxss = to_xcsi2rxssstate(sd);
> > > + int ret;
> > > +
> > > + mutex_lock(&xcsi2rxss->lock);
> > > +
> > > + switch (sub->type) {
> > > + case V4L2_EVENT_XILINX_CSI2RX_SLBF:
> > > + ret = v4l2_event_subscribe(fh, sub, XCSI_MAX_EVENT, NULL);
> >
> > Please either use dev_dbg() or propose an API for conveying this
> > information downstream in the pipeline.
> >
>
> I will use a dev_alert() in the irq handler for this for now and remove this
> event.
dev_dbg(), please, as this is certainly not fatal. We should probably have
an API to tell this to the downstream sub-device driver in the pipeline if
the hardware has no way to detect this independently.
--
Regards,
Sakari Ailus
