On 18-Jul 07:52, Tejun Heo wrote:
> Hello, Patrick.
>
> On Mon, Jul 08, 2019 at 09:43:53AM +0100, Patrick Bellasi wrote:
> > +static inline void cpu_uclamp_print(struct seq_file *sf,
> > + enum uclamp_id clamp_id)
> > +{
> > + struct task_group *tg;
> > + u64 util_clamp;
> > + u64 percent;
> > + u32 rem;
> > +
> > + rcu_read_lock();
> > + tg = css_tg(seq_css(sf));
> > + util_clamp = tg->uclamp_req[clamp_id].value;
> > + rcu_read_unlock();
> > +
> > + if (util_clamp == SCHED_CAPACITY_SCALE) {
> > + seq_puts(sf, "max\n");
> > + return;
> > + }
> > +
> > + percent = uclamp_percent_from_scale(util_clamp);
> > + percent = div_u64_rem(percent, 100, &rem);
> > + seq_printf(sf, "%llu.%u\n", percent, rem);
>
> "%llu.%02u" otherwise 20.01 gets printed as 20.1
Yup!... good point! :)
Since we already collected many feedbacks, I've got a v12 ready for posting.
Maybe you better wait for that before going on with the review.
Thanks,
Patrick
--
#include <best/regards.h>
Patrick Bellasi
