On Fri 19-07-19 10:07:20, Waiman Long wrote: > On 7/19/19 2:14 AM, Michal Hocko wrote: > > On Wed 17-07-19 16:24:13, Waiman Long wrote: > >> The show method of /sys/kernel/slab/<slab>/shrink sysfs file currently > >> returns nothing. This is now modified to show the time of the last > >> cache shrink operation in us. > > Isn't this something that tracing can be used for without any kernel > > modifications? > > That is true, but it will be a bit more cumbersome to get the data.
I have no say for this code but if there is a way to capture timing data I prefer to rely on the tracing infrastructure. If the current tooling makes it cumbersome to get then this is a good reason to ask for a less cumbersome way. On the other hand, if you somehow hardwire it to a user visible interface then you just establish ABI which might stand in way for potential/future development. So take it as my 2c -- Michal Hocko SUSE Labs
