Hi Andra, Just realized one minor issue:
On Fri, Jul 19, 2019 at 9:14 AM andradanciu1997 <[email protected]> wrote: > +&i2c1 { > + clock-frequency = <100000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c1>; > + status = "okay"; > + > + pmic: pmic@4b { > + reg = <0x4b>; > + compatible = "rohm,bd71837"; > + /* PMIC BD71837 PMIC_nINT GPIO1_IO12 */ Comment says gpio1 12... > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pmic>; > + clocks = <&pmic_osc>; > + clock-names = "osc"; > + clock-output-names = "pmic_clk"; > + interrupt-parent = <&gpio1>; > + interrupts = <3 GPIO_ACTIVE_LOW>; but here you use gpio1 3 instead, so there is a mismatch. Please check against the schematics and pick the correct one. I would suggest removing the: /* PMIC BD71837 PMIC_nINT GPIO1_IO12 */ comment entirely. For the next version you can: Reviewed-by: Fabio Estevam <[email protected]> Thanks
