On Mon, 2019-07-22 at 10:36 -0600, [email protected] wrote: > On HP spectre x360 convertible the message: > hid-sensor-hub 001F:8087:0AC2.0002: hid_field_extract() called with n (192) > > 32! (kworker/1:2) > is continually printed many times per second, crowding out all other kernel > logs > Protect dmesg by printing the warning only one time. [] > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c [] > @@ -1311,7 +1311,7 @@ u32 hid_field_extract(const struct hid_device *hid, u8 > *report, > unsigned offset, unsigned n) > { > if (n > 32) { > - hid_warn(hid, "hid_field_extract() called with n (%d) > 32! > (%s)\n", > + hid_warn_once(hid, "hid_field_extract() called with n (%d) > > 32! (%s)\n", > n, current->comm); > n = 32; > }
Is this papering over an actual defect somewhere else? Trivially, this could use "%s: ...", __func__, ...
