On Sun, Jul 21, 2019 at 07:25:31PM -0700, John Hubbard wrote: > On 7/21/19 8:58 AM, Bharath Vedartham wrote: > > For pages that were retained via get_user_pages*(), release those pages > > via the new put_user_page*() routines, instead of via put_page(). > > > > This is part a tree-wide conversion, as described in commit fc1d8e7cca2d > > ("mm: introduce put_user_page*(), placeholder versions"). > > > > Cc: Ira Weiny <ira.we...@intel.com> > > Cc: John Hubbard <jhubb...@nvidia.com> > > Cc: Jérôme Glisse <jgli...@redhat.com> > > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > > Cc: Dimitri Sivanich <sivan...@sgi.com> > > Cc: Arnd Bergmann <a...@arndb.de> > > Cc: linux-kernel@vger.kernel.org > > Cc: linux...@kvack.org > > Signed-off-by: Bharath Vedartham <linux.b...@gmail.com> > > --- > > drivers/misc/sgi-gru/grufault.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Reviewed-by: John Hubbard <jhubb...@nvidia.com> Thanks! > thanks, > -- > John Hubbard > NVIDIA > > > diff --git a/drivers/misc/sgi-gru/grufault.c > > b/drivers/misc/sgi-gru/grufault.c > > index 4b713a8..61b3447 100644 > > --- a/drivers/misc/sgi-gru/grufault.c > > +++ b/drivers/misc/sgi-gru/grufault.c > > @@ -188,7 +188,7 @@ static int non_atomic_pte_lookup(struct vm_area_struct > > *vma, > > if (get_user_pages(vaddr, 1, write ? FOLL_WRITE : 0, &page, NULL) <= 0) > > return -EFAULT; > > *paddr = page_to_phys(page); > > - put_page(page); > > + put_user_page(page); > > return 0; > > } > > > >