On Sep 10 2007 21:58, Jan Engelhardt wrote: >On Sep 10 2007 13:53, Balbir Singh wrote: >>> --- a/mm/memcontrol.c >>> +++ b/mm/memcontrol.c >>> @@ -91,7 +91,7 @@ enum { >>> MEM_CONTAINER_TYPE_CACHED, >>> MEM_CONTAINER_TYPE_ALL, >>> MEM_CONTAINER_TYPE_MAX, >>> -} mem_control_type; >>> +}; >> >>Not sure about this, is this the preferred style?
Humm. Judging from the @@-line, it looks like: enum { MEM_CONTAINER_TYPE_WHATEVER } mem_control_type; making it actually a variable name. Confusing at best. Jan -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/