Re: [PATCH -next] net/ixgbevf: fix a compilation error of skb_frag_t

[Matthew Wilcox]

On Wed, Jul 24, 2019 at 09:32:37AM -0400, Qian Cai wrote:
>       for (f = 0; f < skb_shinfo(skb)->nr_frags; f++)
> -             count += TXD_USE_COUNT(skb_shinfo(skb)->frags[f].size);
> +             count += TXD_USE_COUNT(skb_shinfo(skb)->frags[f].bv_len);
>  #else

No, this is the wrong fix.  Use the fine accessor instead:

+               count += 
TXD_USE_COUNT(skb_frag_size(&skb_shinfo(skb)->frags[f]));

although now there's a line length problem.  Most drivers do:

                skb_frag_t frag = &skb_shinfo(skb)->frags[f];
                count += TXD_USE_COUNT(skb_frag_size(frag));