On Wed, Jul 24, 2019 at 04:26:58PM -0700, Ralph Campbell wrote:
> Struct page for ZONE_DEVICE private pages uses the page->mapping and
> and page->index fields while the source anonymous pages are migrated to
> device private memory. This is so rmap_walk() can find the page when
> migrating the ZONE_DEVICE private page back to system memory.
> ZONE_DEVICE pmem backed fsdax pages also use the page->mapping and
> page->index fields when files are mapped into a process address space.
> 
> Add comments to struct page and remove the unused "_zd_pad_1" field
> to make this more clear.
> 
> Signed-off-by: Ralph Campbell <[email protected]>
> Reviewed-by: John Hubbard <[email protected]>
> Cc: Matthew Wilcox <[email protected]>
> Cc: Vlastimil Babka <[email protected]>
> Cc: Christoph Lameter <[email protected]>
> Cc: Dave Hansen <[email protected]>
> Cc: Jérôme Glisse <[email protected]>
> Cc: "Kirill A . Shutemov" <[email protected]>
> Cc: Lai Jiangshan <[email protected]>
> Cc: Martin Schwidefsky <[email protected]>
> Cc: Pekka Enberg <[email protected]>
> Cc: Randy Dunlap <[email protected]>
> Cc: Andrey Ryabinin <[email protected]>
> Cc: Christoph Hellwig <[email protected]>
> Cc: Jason Gunthorpe <[email protected]>
> Cc: Andrew Morton <[email protected]>
> Cc: Linus Torvalds <[email protected]>
>  include/linux/mm_types.h | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)

Ralph, you marked some of thes patches as mm/hmm, but I feel it is
best if Andrew takes them through the normal -mm path.

They don't touch hmm.c or mmu notifiers so I don't forsee conflicts,
and I don't feel comfortable to review this code.

Regards,
Jason

Reply via email to