Sorry, my bad, I have missed disabling place, and positive feedback
for max in other thread and push me to send it.
On Thu, Jul 25, 2019 at 9:23 AM Krzysztof Kozlowski <k...@kernel.org> wrote:
>
> On Thu, 25 Jul 2019 at 08:37, Vasyl Gomonovych <gomonov...@gmail.com> wrote:
> >
> > Do not fire irq again until thread done
> > This issue was found by code inspection
> > Coccicheck irqf_oneshot.cocci
>
> Rationale does not look convincing. Do you fix real problem or just
> automatic fix from coccinelle? If the latter, then it looks wrong.
> This is virtual IRQ so no need for oneshot. The hardware IRQ has
> oneshot set. Otherwise please provide slightly more specific rationale
> for this commit.
>
> Best regards,
> Krzysztof
>
>
> >
> > Signed-off-by: Vasyl Gomonovych <gomonov...@gmail.com>
> > ---
> > drivers/extcon/extcon-max77693.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/extcon/extcon-max77693.c
> > b/drivers/extcon/extcon-max77693.c
> > index 32fc5a66ffa9..68e42cd87e98 100644
> > --- a/drivers/extcon/extcon-max77693.c
> > +++ b/drivers/extcon/extcon-max77693.c
> > @@ -1142,7 +1142,7 @@ static int max77693_muic_probe(struct platform_device
> > *pdev)
> >
> > ret = devm_request_threaded_irq(&pdev->dev, virq, NULL,
> > max77693_muic_irq_handler,
> > - IRQF_NO_SUSPEND,
> > + IRQF_NO_SUSPEND | IRQF_ONESHOT,
> > muic_irq->name, info);
> > if (ret) {
> > dev_err(&pdev->dev,
> > --
> > 2.17.1
> >
--
Доброї вам пори дня.
