Thanks for the review Greg.

+static int cdns_hw_reset(void *data, u64 value)
+{
+       struct sdw_cdns *cdns = data;
+       int ret;
+
+       if (value != 1)
+               return 0;
+
+       dev_info(cdns->dev, "starting link hw_reset\n");
+
+       ret = sdw_cdns_exit_reset(cdns);
+
+       dev_info(cdns->dev, "link hw_reset done\n");

Do not be noisy for when things always go right.  This looks like
debuggging code, please remove.

yes, missed this in the cleanup, will remove.

+DEFINE_DEBUGFS_ATTRIBUTE(cdns_hw_reset_fops, NULL, cdns_hw_reset, "%llu\n");
+
  /**
   * sdw_cdns_debugfs_init() - Cadence debugfs init
   * @cdns: Cadence instance
@@ -339,6 +358,9 @@ static const struct file_operations cdns_reg_fops = {
  void sdw_cdns_debugfs_init(struct sdw_cdns *cdns, struct dentry *root)
  {
        debugfs_create_file("cdns-registers", 0400, root, cdns, &cdns_reg_fops);
+
+       debugfs_create_file_unsafe("cdns-hw-reset", 0200, root, cdns,
+                                  &cdns_hw_reset_fops);

Why unsafe?

Dunno. I followed the documentation and my take-away, along with a number of examples, was to use _unsafe. I really have no idea if this is correct or not, I can remove this qualifier if that's not needed.

Reply via email to