From: Huazhong Tan <tanhuazh...@huawei.com> Date: Sat, 27 Jul 2019 13:46:08 +0800
> From: Yonglong Liu <liuyongl...@huawei.com> > > Some times just see the eth interface have been down/up via > dmesg, but can not know why the eth down. So adds some debug > messages to identify the cause for this. > > Signed-off-by: Yonglong Liu <liuyongl...@huawei.com> > Signed-off-by: Peng Li <lipeng...@huawei.com> > Signed-off-by: Huazhong Tan <tanhuazh...@huawei.com> > --- > drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 18 ++++++++++++++++++ > drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 19 > +++++++++++++++++++ > .../net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c | 11 +++++++++++ > 3 files changed, 48 insertions(+) > > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > index 4d58c53..973c57b 100644 > --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > @@ -459,6 +459,9 @@ static int hns3_nic_net_open(struct net_device *netdev) > h->ae_algo->ops->set_timer_task(priv->ae_handle, true); > > hns3_config_xps(priv); > + > + netif_info(h, drv, netdev, "net open\n"); These will pollute everyone's kernel logs for normal operations. This is not reasonable at all, sorry. Furthermore, even if it was appropriate, "netif_info()" is not "debug".
