On Sun, Jul 28, 2019 at 12:22:30AM +0200, Christian Brauner wrote: > Add tests for pidfd_wait() and CLONE_WAIT_PID: > - test that waitid(P_PIDFD) can wait on a pidfd > - test that waitid(P_PIDFD) can wait on a pidfd and return siginfo_t > - test that waitid(P_PIDFD) works with WEXITED > - test that waitid(P_PIDFD) works with WSTOPPED > - test that waitid(P_PIDFD) works with WUNTRACED > - test that waitid(P_PIDFD) works with WCONTINUED > - test that waitid(P_PIDFD) works with WNOWAIT > - test that waitid(P_PIDFD)works with WNOHANG
Reviewed-by: Kees Cook <[email protected]> This all looks good to me! :) One note that doesn't apply to this patch in particular, but might be nice to add (as I didn't see in the existing tests) was testing for pathological conditions: passing in /dev/zero for the pidfd, etc. (Maybe I missed those?) -- Kees Cook
