Re: [PATCH] ARM: signal: Mark expected switch fall-through

[Kees Cook]

On Sun, Jul 28, 2019 at 07:13:14PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
> 
> This patch fixes the following warning:
> 
> arch/arm/kernel/signal.c: In function 'do_signal':
> arch/arm/kernel/signal.c:598:12: warning: this statement may fall through 
> [-Wimplicit-fallthrough=]
>     restart -= 2;
>     ~~~~~~~~^~~~
> arch/arm/kernel/signal.c:599:3: note: here
>    case -ERESTARTNOHAND:
>    ^~~~
> 
> Reported-by: Stephen Rothwell <s...@canb.auug.org.au>
> Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com>

Reviewed-by: Kees Cook <keesc...@chromium.org>

-Kees

> ---
>  arch/arm/kernel/signal.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/kernel/signal.c b/arch/arm/kernel/signal.c
> index 09f6fdd41974..ab2568996ddb 100644
> --- a/arch/arm/kernel/signal.c
> +++ b/arch/arm/kernel/signal.c
> @@ -596,6 +596,7 @@ static int do_signal(struct pt_regs *regs, int syscall)
>               switch (retval) {
>               case -ERESTART_RESTARTBLOCK:
>                       restart -= 2;
> +                     /* Fall through */
>               case -ERESTARTNOHAND:
>               case -ERESTARTSYS:
>               case -ERESTARTNOINTR:
> -- 
> 2.22.0
> 

-- 
Kees Cook