On Tue, Jul 30, 2019 at 11:15:48AM -0700, Stephen Boyd wrote:
> We don't need dev_err() messages when platform_get_irq() fails now that
> platform_get_irq() prints an error message itself when something goes
> wrong. Let's remove these prints with a simple semantic patch.
>
> // <smpl>
> @@
> expression ret;
> struct platform_device *E;
> @@
>
> ret =
> (
> platform_get_irq(E, ...)
> |
> platform_get_irq_byname(E, ...)
> );
>
> if ( \( ret < 0 \| ret <= 0 \) )
> {
> (
> -if (ret != -EPROBE_DEFER)
> -{ ...
> -dev_err(...);
> -... }
> |
> ...
> -dev_err(...);
> )
> ...
> }
> // </smpl>
>
> While we're here, remove braces on if statements that only have one
> statement (manually).
>
> Cc: Wim Van Sebroeck <w...@linux-watchdog.org>
> Cc: Guenter Roeck <li...@roeck-us.net>
> Cc: linux-watch...@vger.kernel.org
> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> Signed-off-by: Stephen Boyd <swb...@chromium.org>
Reviewed-by: Guenter Roeck <li...@roeck-us.net>
> ---
>
> Please apply directly to subsystem trees
>
> drivers/watchdog/sprd_wdt.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/watchdog/sprd_wdt.c b/drivers/watchdog/sprd_wdt.c
> index edba4e278685..0bb17b046140 100644
> --- a/drivers/watchdog/sprd_wdt.c
> +++ b/drivers/watchdog/sprd_wdt.c
> @@ -284,10 +284,8 @@ static int sprd_wdt_probe(struct platform_device *pdev)
> }
>
> wdt->irq = platform_get_irq(pdev, 0);
> - if (wdt->irq < 0) {
> - dev_err(dev, "failed to get IRQ resource\n");
> + if (wdt->irq < 0)
> return wdt->irq;
> - }
>
> ret = devm_request_irq(dev, wdt->irq, sprd_wdt_isr, IRQF_NO_SUSPEND,
> "sprd-wdt", (void *)wdt);
> --
> Sent by a computer through tubes
>
