On Tue, Jul 30, 2019 at 11:48:09AM -0700, Stephen Boyd wrote: > Quoting Tri Vo (2019-07-30 11:39:34) > > On Mon, Jul 29, 2019 at 10:46 PM Rafael J. Wysocki <[email protected]> > > wrote: > > > > > > On Tue, Jul 30, 2019 at 4:45 AM Tri Vo <[email protected]> wrote: > > > > - Device registering the wakeup source is now the parent of the wakeup > > > > source. > > > > Updated wakeup_source_register()'s signature and its callers > > > > accordingly. > > > > > > And I really don't like these changes. Especially having "wakeup" > > > twice in the path. > > > > I can trim it down to /sys/class/wakeup/<ID>/. Does that sound good? > > Using the same prefix for the class and the device name is quite common. > For example, see the input, regulator, tty, tpm, remoteproc, hwmon, > extcon classes. I'd prefer it was left as /sys/class/wakeup/wakeupN. The > class name could be changed to wakeup_source perhaps (i.e. > /sys/class/wakeup_source/wakeupN)? >
Ah, the issue is that these end up on the virtual "bus". Yeah, sorry, you are right, they need to have a unique prefix in order to prevent name collisions. thanks, greg k-h
