> -----Original Message----- > From: Keith Busch <[email protected]> > Sent: Tuesday, July 30, 2019 2:20 PM > To: Kai-Heng Feng > Cc: Limonciello, Mario; [email protected]; [email protected]; > [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected] > Subject: Re: [Regression] Commit "nvme/pci: Use host managed power state for > suspend" has problems > > > [EXTERNAL EMAIL] > > On Wed, Jul 31, 2019 at 02:50:01AM +0800, Kai-Heng Feng wrote: > > > > Just did a quick test, this patch regress SK Hynix BC501, the SoC stays at > > PC3 once the patch is applied. > > Okay, I'm afraid device/platform quirks may be required unless there are > any other ideas out there.
I think if a quirk goes in for Rafael's SSD it would have to be a quirk specific to this device and FW version per the findings on KH checking the same device with the older FW version. > > I'm not a big fan of adding more params to this driver. Those are > global to the module, so that couldn't really handle a platform with > two different devices that want different behavior.
