> From: Michael Kelley <[email protected]> > Sent: Tuesday, July 30, 2019 3:36 PM > > From: Dexuan Cui <[email protected]> Sent: Monday, July 8, 2019 10:29 > PM > > > > There is only one functional change: the unnecessary check > > "if (sctrl.enable != 1) return -EFAULT;" is removed, because when we're in > > hv_synic_cleanup(), we're absolutely sure sctrl.enable must be 1. > > > > The new functions hv_synic_disable/enable_regs() will be used by a later > patch > > to support hibernation. > > Seems like this commit message doesn't really describe the main change. > How about: > > Break out synic enable and disable operations into separate > hv_synic_disable_regs() and hv_synic_enable_regs() functions for use by a > later patch to support hibernation. > > There is no functional change except the unnecessary check > "if (sctrl.enable != 1) return -EFAULT;" is removed, because when we're in > hv_synic_cleanup(), we're absolutely sure sctrl.enable must be 1. > > Otherwise, > > Reviewed-by: Michael Kelley <[email protected]>
Thanks! I'll use your version as the changelog of v2. I'll change the Subject accordingly. Thanks, -- Dexuan
