On Tue, Jul 30, 2019 at 8:51 AM Greg Kroah-Hartman <[email protected]> wrote: > > On Mon, Jul 29, 2019 at 12:52:08PM -0700, Andrey Smirnov wrote: > > Sg_init_one() will already call sg_set_buf(), so another explicit call > > right after it is unnecessary. Drop it. > > > > Signed-off-by: Andrey Smirnov <[email protected]> > > Cc: Stefan Agner <[email protected]> > > Cc: Bhuvanchandra DV <[email protected]> > > Cc: Chris Healy <[email protected]> > > Cc: Cory Tusar <[email protected]> > > Cc: Lucas Stach <[email protected]> > > Cc: Greg Kroah-Hartman <[email protected]> > > Cc: Jiri Slaby <[email protected]> > > Cc: [email protected] > > Cc: [email protected] > > Cc: [email protected] > > --- > > drivers/tty/serial/fsl_lpuart.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/tty/serial/fsl_lpuart.c > > b/drivers/tty/serial/fsl_lpuart.c > > index 1b3f2a87e558..b600f591c8c2 100644 > > --- a/drivers/tty/serial/fsl_lpuart.c > > +++ b/drivers/tty/serial/fsl_lpuart.c > > @@ -1144,7 +1144,6 @@ static inline int lpuart_start_rx_dma(struct > > lpuart_port *sport) > > return -ENOMEM; > > > > sg_init_one(&sport->rx_sgl, ring->buf, sport->rx_dma_rng_buf_len); > > - sg_set_buf(&sport->rx_sgl, ring->buf, sport->rx_dma_rng_buf_len); > > nent = dma_map_sg(sport->port.dev, &sport->rx_sgl, 1, > > DMA_FROM_DEVICE); > > > > if (!nent) { > > This patch doesn't apply, is it already in the tree from someone else? >
Yeah, looks like d9aa9ab4fe6b5c43b9ccb8a0811dadcfe40ea27f from your tty tree already covered this and I didn't have it in my tree. Will drop in v2. Thanks, Andrey Smirnov
