On 2019/7/31 19:29, Hans de Goede wrote:
> Hi Petr,
>
> On 31-07-19 13:06, Petr Vorel wrote:
>> Hi,
>>
>>>> In delayedwork_callback(), logi_dj_recv_query_paired_devices
>>>> may return positive value while success now, so check it
>>>> correctly.
>>
>>>> Fixes: dbcbabf7da92 ("HID: logitech-dj: fix return value of
>>>> logi_dj_recv_query_hidpp_devices")
>>>> Signed-off-by: YueHaibing <[email protected]>
>>> Reviewed-by: Petr Vorel <[email protected]>
>> OK, not only it didn't fix problems with logitech mouse (see below),
>> but removing mouses USB dongle effectively crashes kernel, so this one
>> probably
>> shouldn't be applied :).
>>
>> [ 330.721629] logitech-djreceiver: probe of 0003:046D:C52F.0013 failed with
>> error 7
>> [ 331.462335] hid 0003:046D:C52F.0013: delayedwork_callback:
>> logi_dj_recv_query_paired_devices error: 7
>
> Please test my patch titled: "HID: logitech-dj: Really fix return value of
> logi_dj_recv_query_hidpp_devices"
> which should fix this.
Yes, this is better one, thanks!
>
> Regards,
>
> Hans
>
> .
>
