On Wed, 31 Jul 2019 09:12:14 +0000
<tudor.amba...@microchip.com> wrote:
> static inline bool spi_nor_protocol_is_dtr(enum spi_nor_protocol proto)
> {
> return !!(proto & SNOR_PROTO_IS_DTR);
> @@ -384,6 +522,7 @@ struct flash_info;
> * useful when pagesize is not a power-of-2
> * @disable_write_protection: [FLASH-SPECIFIC] disable write protection
> during
> * power-up
> + * @setup: [FLASH-SPECIFIC] configure the spi-nor memory
Might be worth giving a example of the type of configuration that can
be done here.
The patch looks good otherwise.
Reviewed-by: Boris Brezillon <boris.brezil...@collabora.com>
> * completely locked
Looks like this 'completely locked' is a leftover from a previous move
(lock functions were move to a separate _ops struct IIRC). Can you fix
that?
> * @priv: the private data
> */
> @@ -427,6 +566,9 @@ struct spi_nor {
> int (*set_4byte)(struct spi_nor *nor, bool enable);
> u32 (*convert_addr)(struct spi_nor *nor, u32 addr);
> int (*disable_write_protection)(struct spi_nor *nor);
> + int (*setup)(struct spi_nor *nor,
> + const struct spi_nor_flash_parameter *params,
> + const struct spi_nor_hwcaps *hwcaps);
>
> const struct spi_nor_locking_ops *locking_ops;
>
> @@ -486,81 +628,6 @@ static inline struct device_node
> *spi_nor_get_flash_node(struct spi_nor *nor)
> }
>
