Hi Oleksij, Thanks for review
<snip> > > your patch is in conflicht with Richard's Zhu <hongxing....@nxp.com> > patch "[PATCH v3] mailbox: imx: add support for imx v1 mu". > Please sync your works. Sent an email to Richard. Hopefully he can rebase his change on my patches. <snip> > > Looks like here is one more bug "from the beginning of times" :) > The imx_mu_xcr_rmw() should disable only one channel depending on the > type of channel. > > It should be: > switch (cp->type) { > case IMX_MU_TYPE_TX: > imx_mu_xcr_rmw(priv, 0, IMX_MU_xCR_TIEn(cp->idx)); > break; > case IMX_MU_TYPE_RX: > imx_mu_xcr_rmw(priv, 0, IMX_MU_xCR_RIEn(cp->idx)); > break; > case IMX_MU_TYPE_RXDB: > imx_mu_xcr_rmw(priv, 0, IMX_MU_xCR_GIEn(cp->idx)); > break; > default: > break; Honestly, this is not really a bug. The registers are expected to already be cleared. Also, please mind that we shouldn't clear TIE here because it should be cleared in the mu_isr. Anyhow, I have sent the patches with your exact suggestion to Richard. > } > > Right now I'm on vocation and have nothing against, if you'll provide > this fix. Have a nice vacation and thanks for the review.