Re: [patch 2/5] x86/kvm: Handle task_work on VMENTER/EXIT

[Oleg Nesterov]

On 08/01, Thomas Gleixner wrote:
>
> @@ -8172,6 +8174,10 @@ static int vcpu_run(struct kvm_vcpu *vcp
>                       ++vcpu->stat.signal_exits;
>                       break;
>               }
> +
> +             if (notify_resume_pending())
> +                     tracehook_handle_notify_resume();

shouldn't you drop kvm->srcu before tracehook_handle_notify_resume() ?

I don't understand this code at all, but vcpu_run() does this even before
cond_resched().

Oleg.