On 01/08/19 1:05 AM, Stephen Boyd wrote: > A future patch is going to change semantics of clk_register() so that > clk_hw::init is guaranteed to be NULL after a clk is registered. Avoid > referencing this member here so that we don't run into NULL pointer > exceptions. > > Cc: Roger Quadros <rog...@ti.com> > Cc: Kishon Vijay Abraham I <kis...@ti.com> > Signed-off-by: Stephen Boyd <sb...@kernel.org> > --- > > Please ack so I can take this through clk tree Acked-by: Kishon Vijay Abraham I <kis...@ti.com> > > drivers/phy/ti/phy-am654-serdes.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/ti/phy-am654-serdes.c > b/drivers/phy/ti/phy-am654-serdes.c > index f8edd0840fa2..398a8c9b675a 100644 > --- a/drivers/phy/ti/phy-am654-serdes.c > +++ b/drivers/phy/ti/phy-am654-serdes.c > @@ -335,6 +335,7 @@ static int serdes_am654_clk_mux_set_parent(struct clk_hw > *hw, u8 index) > { > struct serdes_am654_clk_mux *mux = to_serdes_am654_clk_mux(hw); > struct regmap *regmap = mux->regmap; > + const char *name = clk_hw_get_name(hw); > unsigned int reg = mux->reg; > int clk_id = mux->clk_id; > int parents[SERDES_NUM_CLOCKS]; > @@ -374,8 +375,7 @@ static int serdes_am654_clk_mux_set_parent(struct clk_hw > *hw, u8 index) > * This can never happen, unless we missed > * a valid combination in serdes_am654_mux_table. > */ > - WARN(1, "Failed to find the parent of %s clock\n", > - hw->init->name); > + WARN(1, "Failed to find the parent of %s clock\n", name); > return -EINVAL; > } > >