Hi Robert,
On 24/06/2019 16:09, Robert Richter wrote:
> Use standard macros for page calculations.
>
> Signed-off-by: Robert Richter <[email protected]>
> ---
> diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c
> index 786f1b32eee1..746083876b5f 100644
> --- a/drivers/edac/ghes_edac.c
> +++ b/drivers/edac/ghes_edac.c
> @@ -311,8 +311,8 @@ void ghes_edac_report_mem_error(int sev, struct
> cper_sec_mem_err *mem_err)
>
> /* Error address */
> if (mem_err->validation_bits & CPER_MEM_VALID_PA) {
> - e->page_frame_number = mem_err->physical_addr >> PAGE_SHIFT;
> - e->offset_in_page = mem_err->physical_addr & ~PAGE_MASK;
> + e->page_frame_number = PHYS_PFN(mem_err->physical_addr);
> + e->offset_in_page = offset_in_page(mem_err->physical_addr);
> }
>
> /* Error grain */
>
After a shorter game of spot-the-difference:
Reviewed-by: James Morse <[email protected]>
Previously here:
https://lore.kernel.org/linux-edac/[email protected]/
Please pick up tags when posting a new version.
If you don't do this, its very difficult to convince people to spend time
reviewing your
series.
Thanks,
James
