On 08/01/2019 09:36 AM, Boris Brezillon wrote:
> On Wed, 31 Jul 2019 09:12:14 +0000
> <tudor.amba...@microchip.com> wrote:
>
>
>> static inline bool spi_nor_protocol_is_dtr(enum spi_nor_protocol proto)
>> {
>> return !!(proto & SNOR_PROTO_IS_DTR);
>> @@ -384,6 +522,7 @@ struct flash_info;
>> * useful when pagesize is not a power-of-2
>> * @disable_write_protection: [FLASH-SPECIFIC] disable write protection
>> during
>> * power-up
>> + * @setup: [FLASH-SPECIFIC] configure the spi-nor memory
>
> Might be worth giving a example of the type of configuration that can
> be done here.
will do
>
> The patch looks good otherwise.
>
> Reviewed-by: Boris Brezillon <boris.brezil...@collabora.com>
>
>> * completely locked
>
> Looks like this 'completely locked' is a leftover from a previous move
> (lock functions were move to a separate _ops struct IIRC). Can you fix
> that?
there's already a patch on ML for this, I'll apply it.
Thanks,
ta
