On Fri, Sep 14 2007, Nick Piggin wrote: > > Should add some comments for the tag barriers (they won't be so important > if we can switch over to the explicit _lock bitops, but for now we should > make it clear).
Thanks! > Jens' original patch said a barrier after the test_and_clear_bit was also > required. I can't see why (and it would prevent the use of the _lock bitop). Yeah, I don't think it's needed either. The important bit was ordering the ->tag_index[tag] = NULL setting before clearing the bit, and as long as those two operations are ordered, we are good to go. So the last memory barrier was not needed. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
