On Mon, 5 Aug 2019 17:55:15 +0200 Jacopo Mondi <jacopo+rene...@jmondi.org> wrote:
> The max9611 driver reads the die temperature at probe time to validate > the communication channel. Use the actual read value to perform the test > instead of the read function return value, which was mistakenly used so > far. > > The temperature reading test was only successful because the 0 return > value is in the range of supported temperatures. > > Fixes: 69780a3bbc0b ("iio: adc: Add Maxim max9611 ADC driver") > Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> Applied to the fixes-togreg branch of iio.git and marked for stable. That'll be a bit fiddly given other changes around this so we may need to do backports. > --- > drivers/iio/adc/max9611.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/max9611.c b/drivers/iio/adc/max9611.c > index 917223d5ff5b..e9f6b1da1b94 100644 > --- a/drivers/iio/adc/max9611.c > +++ b/drivers/iio/adc/max9611.c > @@ -480,7 +480,7 @@ static int max9611_init(struct max9611_dev *max9611) > if (ret) > return ret; > > - regval = ret & MAX9611_TEMP_MASK; > + regval &= MAX9611_TEMP_MASK; > > if ((regval > MAX9611_TEMP_MAX_POS && > regval < MAX9611_TEMP_MIN_NEG) || > -- > 2.22.0 >