On 8/5/19 11:27 AM, Sagi Grimberg wrote: > >>> Ping ? I had another look today and I don't feel like mucking around >>> with all the AQ size logic, AEN magic tag etc... just for that sake of >>> that Apple gunk. I'm happy to have it give up IO tags, it doesn't seem >>> to make much of a difference in practice anyway. >>> >>> But if you feel strongly about it, then I'll implement the "proper" way >>> sometimes this week, adding a way to shrink the AQ down to something >>> like 3 (one admin request, one async event (AEN), and the empty slot) >>> by making a bunch of the constants involved variables instead. >> >> I don't feel too strongly about it. I think your patch is fine, so >> >> Acked-by: Keith Busch <keith.bu...@intel.com> > > Should we pick this up for 5.3-rc?
No, it's not a regression fix. Queue it up for 5.4 instead. -- Jens Axboe
