Quoting Tri Vo (2019-08-05 14:11:55) > On Mon, Aug 5, 2019 at 1:54 PM Stephen Boyd <swb...@chromium.org> wrote: > > > > Quoting Tri Vo (2019-08-05 10:58:46) > > > @@ -96,13 +79,23 @@ EXPORT_SYMBOL_GPL(wakeup_source_prepare); > > > struct wakeup_source *wakeup_source_create(const char *name) > > > { > > > struct wakeup_source *ws; > > > + const char *ws_name; > > > > > > - ws = kmalloc(sizeof(*ws), GFP_KERNEL); > > > + ws = kzalloc(sizeof(*ws), GFP_KERNEL); > > > if (!ws) > > > - return NULL; > > > + goto err_ws; > > > + > > > + ws_name = kstrdup_const(name, GFP_KERNEL); > > > + if (!ws_name) > > > > Does this intentionally change this function to return an error if > > 'name' is NULL? Before, wakeup_source_prepare() would just assign > > ws->name to NULL, but now it errors out. I don't see how it's good or > > useful to allow NULL for the wakeup source name, but it is what it is. > > Yes, the change to not allow ws->name to be NULL is intentional.
Ok. It would be good to mention it in the commit text so we don't think it was a bug when looking back a few months later.