On Mon, Aug 5, 2019 at 2:42 PM Bowers, AndrewX <[email protected]> wrote: > > > -----Original Message----- > > From: Intel-wired-lan [mailto:[email protected]] On > > Behalf Of Chuhong Yuan > > Sent: Friday, August 2, 2019 3:55 AM > > Cc: [email protected]; Chuhong Yuan <[email protected]>; linux- > > [email protected]; [email protected]; David S . Miller > > <[email protected]> > > Subject: [Intel-wired-lan] [PATCH 1/2] ixgbe: Explicitly initialize > > reference > > count to 0 > > > > The driver does not explicitly call atomic_set to initialize refcount to 0. > > Add the call so that it will be more straight forward to convert refcount > > from > > atomic_t to refcount_t. > > > > Signed-off-by: Chuhong Yuan <[email protected]> > > --- > > drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 1 + > > 1 file changed, 1 insertion(+) > > Tested-by: Andrew Bowers <[email protected]>
NAK. This patch is badly broken. We should not be resetting the fcoe refcnt in ixgbe_setup_fcoe_ddp_resources.
