On Mon, 2019-08-05 at 16:16 +0200, Andrew Lunn wrote:
> [External]
> 
> > +static int adin_config_init(struct phy_device *phydev)
> > +{
> > +   int rc;
> > +
> > +   rc = genphy_config_init(phydev);
> > +   if (rc < 0)
> > +           return rc;
> > +
> > +   return 0;
> > +}
> 
> Why not just
> 
>     return genphy_config_init(phydev);

Because stuff will get added after this return statement in the next patches.
I thought maybe this would be a good idea to keep the git changes minimal, but 
I can do a direct return and update it in
the next patches when needed.

> 
>     Andrew
> 

Reply via email to