Hi Belloni, On Mon, 2019-08-05 at 09:23 +0200, Alexandre Belloni wrote: > Hi, > > The subject should be: > > "rtc: mt6397: Add support for the MediaTek MT6358 RTC"
Will be changed at next patch. > > +struct mtk_rtc_compatible { > > I would name that struct mtk_rtc_data > > > + u32 wrtgr_addr; > > and this member should be wrtgr_offset or simply wrtgr. > Will be changed at next patch. > > > > + of_id = of_match_device(mt6397_rtc_of_match, &pdev->dev); > > + if (!of_id) { > > + dev_err(&pdev->dev, "Failed to probe of_node\n"); > > + return -EINVAL; > > This will never happen because probe would not be called if there is no > match. You could also use of_device_get_match_data to avoid having to > move the of_device_id table. > Will use of_device_get_match_data() function instead of of_match_device() function.