From: Srinivas Kandagatla <srinivas.kandaga...@linaro.org> Sent: Tuesday, August 6, 2019 6:04 PM > On 04/07/2019 15:20, fugang.d...@nxp.com wrote: > > From: Fugang Duan <fugang.d...@nxp.com> > > > > i.MX8QM efuse table has some difference with i.MX8QXP platform, so add > > i.MX8QM platform support. > > > > Signed-off-by: Fugang Duan <fugang.d...@nxp.com> > > --- > > drivers/nvmem/imx-ocotp-scu.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/nvmem/imx-ocotp-scu.c > > b/drivers/nvmem/imx-ocotp-scu.c index be2f5f0..0d78ab4 100644 > > --- a/drivers/nvmem/imx-ocotp-scu.c > > +++ b/drivers/nvmem/imx-ocotp-scu.c > > @@ -16,6 +16,7 @@ > > > > enum ocotp_devtype { > > IMX8QXP, > > + IMX8QM, > > }; > > > > struct ocotp_devtype_data { > > @@ -39,6 +40,11 @@ static struct ocotp_devtype_data imx8qxp_data = { > > .nregs = 800, > > }; > > > > +static struct ocotp_devtype_data imx8qm_data = { > > + .devtype = IMX8QM, > > + .nregs = 800, > > +}; > > + > > static int imx_sc_misc_otp_fuse_read(struct imx_sc_ipc *ipc, u32 word, > > u32 *val) > > { > > @@ -118,6 +124,7 @@ static struct nvmem_config > > imx_scu_ocotp_nvmem_config = { > > > > static const struct of_device_id imx_scu_ocotp_dt_ids[] = { > > { .compatible = "fsl,imx8qxp-scu-ocotp", (void *)&imx8qxp_data > > }, > > + { .compatible = "fsl,imx8qm-scu-ocotp", (void *)&imx8qm_data }, > > { }, > > Looks like you forgot to add this new compatible to device tree bindings > at ./Documentation/devicetree/bindings/nvmem/imx-ocotp.txt or forgot to > add me to CC. > > Please resend the patch with it, I can not apply this as it is. > > Thanks, > srini
There have no separated binding documentation for imx-ocotp-scu.c driver. It is reasonable to add the new compatible string on below binding file "fsl,scu.txt": Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > > }; > > MODULE_DEVICE_TABLE(of, imx_scu_ocotp_dt_ids); > >