On 03/08/2019 18:34, Marc Zyngier wrote: > On Sat, 3 Aug 2019 13:51:13 +0100 > Marc Zyngier <[email protected]> wrote: > > [forgot that one] > >> On Fri, 2 Aug 2019 15:50:14 +0100 >> Steven Price <[email protected]> wrote: > > [...] > >>> +static int __init kvm_pvtime_init(void) >>> +{ >>> + kvm_register_device_ops(&pvtime_ops, KVM_DEV_TYPE_ARM_PV_TIME); >>> + >>> + return 0; >>> +} >>> + >>> +late_initcall(kvm_pvtime_init); > > Why is it an initcall? So far, the only initcall we've used is the one > that initializes KVM itself. Can't we just the device_ops just like we > do for the vgic?
So would you prefer a direct call from init_subsystems() in virt/kvm/arm/arm.c? The benefit of initcall is just that it keeps the code self-contained. In init_subsystems() I'd either need a #ifdef CONFIG_ARM64 or a dummy function for arm. Steve
