On Wed, 2019-08-07 at 23:55 +0900, Masahiro Yamada wrote: > On Wed, Aug 7, 2019 at 11:27 PM Guenter Roeck <li...@roeck-us.net> wrote: [] > > Who is going to fix the fallout ? For example, arm64:defconfig no longer > > compiles with this patch applied. > > > > It seems to me that the benefit of catching misuses of GENMASK is much > > less than the fallout from no longer compiling kernels, since those > > kernels won't get any test coverage at all anymore. > > We cannot apply this until we fix all errors. > I do not understand why Andrew picked up this so soon.
I think it makes complete sense to break -next (not mainline) and force people to fix defects. Especially these types of defects that are trivial to fix. I already sent patches a month ago for all decimal only defective uses of GENMASK https://lore.kernel.org/lkml/cover.1562734889.git....@perches.com/ A couple of which have _still_ not been picked up. These have been applied in -next: 1 9e037bdf743cc081858423ad4123824e846b2358 media: staging: media: cedrus: Fix misuse of GENMASK macro 2 5ff29d836d1beb347080bd96e6321c811a8e3f62 rtw88: Fix misuse of GENMASK macro 3 665e985c2f41bebc3e6cee7e04c36a44afbc58f7 mmc: meson-mx-sdio: Fix misuse of GENMASK macro 4 f7408a3d5b5fd10571a653d1a81ce9167c62727f ASoC: wcd9335: Fix misuse of GENMASK macro 5 ae8cc91a7d85e018c0c267f580820b2bb558cd48 iio: adc: max9611: Fix misuse of GENMASK macro 6 aa4c0c9091b0bb4cb261bbe0718d17c2834c4690 net: stmmac: Fix misuses of GENMASK macro 7 937a944090cca2f19458fd037a8aff61c546f0cd net: ethernet: mediatek: Fix misuses of GENMASK macro 8 9bdd7bb3a8447fe841cd37ddd9e0a6974b06a0bb clocksource/drivers/npcm: Fix misuse of GENMASK macro 9 20faba848752901de23a4d45a1174d64d2069dde irqchip/gic-v3-its: Fix misuse of GENMASK macro These have not: (and that's a rather sad indictment of lk process defects) [PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro https://lore.kernel.org/lkml/cddd7ad7e9f81dec1e86c106f04229d21fc21920.1562734889.git....@perches.com/ [PATCH 10/12] phy: amlogic: G12A: Fix misuse of GENMASK macro https://lore.kernel.org/lkml/d149d2851f9aa2425c927cb8e311e20c4b83e186.1562734889.git....@perches.com/ At least these last two do not seem to have actual uses.
