On Thu, 08 Aug 2019 11:31:01 +0200, Borislav Petkov said: > > There's no reason to build the debugfs.o if the kernel config doesn't > > even include CONFIG_DEBUG_FS > > > > Signed-off-by: Valdis Kletnieks <[email protected]> > > > > diff --git a/drivers/ras/Makefile b/drivers/ras/Makefile > > index ef6777e14d3d..07a5c391cc23 100644 > > --- a/drivers/ras/Makefile > > +++ b/drivers/ras/Makefile > > @@ -1,3 +1,6 @@ > > # SPDX-License-Identifier: GPL-2.0-only > > -obj-$(CONFIG_RAS) += ras.o debugfs.o > > +obj-$(CONFIG_RAS) += ras.o > > +ifeq ($(CONFIG_DEBUG_FS),y) > > +obj-$(CONFIG_RAS) += debugfs.o > > +endif > > obj-$(CONFIG_RAS_CEC) += cec.o > > If this is not causing real trouble then I'd prefer to keep it this way > because ras.c is pretty useless without the debugfs functionality.
It's needed if somebody applies the patch 2/2 - and I just got a note from the kbuild test robot saying that happened.... And if it's that useless, maybe *more* needs to be done to ensure that debugfs is enabled if ras is being built - possibly a Kconfig 'select' or something....
pgpIldEPh3AQs.pgp
Description: PGP signature
