Hi, David Miller <[email protected]> writes:
> From: YueHaibing <[email protected]> > Date: Thu, 8 Aug 2019 22:26:23 +0800 > >> net/sched/sch_taprio.c:680:32: warning: >> entry_list_policy defined but not used [-Wunused-const-variable=] >> >> It is not used since commit a3d43c0d56f1 ("taprio: Add >> support adding an admin schedule") >> >> Reported-by: Hulk Robot <[email protected]> >> Signed-off-by: YueHaibing <[email protected]> > > This is probably unintentional and a bug, we should be using that > policy value to validate that the sched list is indeed a nested > attribute. Removing this policy should be fine. One of the points of commit (as explained in the commit message) a3d43c0d56f1 ("taprio: Add support adding an admin schedule") is that it removes support (it now returns "not supported") for schedules using the TCA_TAPRIO_ATTR_SCHED_SINGLE_ENTRY attribute (which were never used), the parsing of those types of schedules was the only user of this policy. > > I'm not applying this without at least a better and clear commit > message explaining why we shouldn't be using this policy any more. YueHaibing may use the text above in the commit message of a new spin of this patch if you think it's clear enough. Cheers, -- Vinicius
