On Sat, 2019-08-10 at 21:40 +0100, Ben Hutchings wrote: > 3.16.72-rc1 review patch. If anyone has any objections, please let me know.
Unless to enable applying further patches, I doubt there is ever a need to have any of Markus Elfring's patches applied to any -stable kernel. > ------------------ > > From: Markus Elfring <[email protected]> > > commit 057ac1acdfc4743f066fcefe359385cad00549eb upstream. > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <[email protected]> > Signed-off-by: Jonathan Cameron <[email protected]> > Signed-off-by: Ben Hutchings <[email protected]> > --- > drivers/iio/industrialio-buffer.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > --- a/drivers/iio/industrialio-buffer.c > +++ b/drivers/iio/industrialio-buffer.c > @@ -836,10 +836,9 @@ int iio_scan_mask_set(struct iio_dev *in > const unsigned long *mask; > unsigned long *trialmask; > > - trialmask = kmalloc(sizeof(*trialmask)* > - BITS_TO_LONGS(indio_dev->masklength), > - GFP_KERNEL); > - > + trialmask = kmalloc_array(BITS_TO_LONGS(indio_dev->masklength), > + sizeof(*trialmask), > + GFP_KERNEL); > if (trialmask == NULL) > return -ENOMEM; > if (!indio_dev->masklength) { >
