Hi Alex, > usb reset resume will cause downloading firmware again and > requesting firmware may be failed while host is resuming > > Signed-off-by: Alex Lu <[email protected]> > --- > drivers/bluetooth/btrtl.c | 101 ++++++++++++++++++++++++++++++++++++-- > 1 file changed, 97 insertions(+), 4 deletions(-) > > diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c > index 208feef63de4..416a5cb676e3 100644 > --- a/drivers/bluetooth/btrtl.c > +++ b/drivers/bluetooth/btrtl.c > @@ -56,6 +56,8 @@ struct btrtl_device_info { > int cfg_len; > }; > > +static struct btrtl_device_info dev_info; > +
No. We are are not using magic global variables. What happens if you attach more than one device? Also I assumed that request_firmware has a caching capability of sorts so that drivers don’t have to re-implement caching of the firmware. Regards Marcel
