On Mon, 2019-08-12 at 11:20 -0700, Nick Desaulniers wrote:
> On Fri, Aug 9, 2019 at 4:17 PM Joe Perches <[email protected]> wrote:
> > On Fri, 2019-08-09 at 16:04 -0700, Nick Desaulniers wrote:
> > > > how about:
> > > > ---
> > > > scripts/checkpatch.pl | 9 +++++++++
> > > > 1 file changed, 9 insertions(+)
> > > >
> > > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > > > index 1cdacb4fd207..8e6693ca772c 100755
> > > > --- a/scripts/checkpatch.pl
> > > > +++ b/scripts/checkpatch.pl
> > > > @@ -5901,6 +5901,15 @@ sub process {
> > > > "__aligned(size) is preferred over
> > > > __attribute__((aligned(size)))\n" . $herecurr);
> > > > }
> > > >
> > > > +# Check for __attribute__ section, prefer __section (without quotes)
> > > > + if ($realfile !~ m@\binclude/uapi/@ &&
> > > > + $line =~
> > > > /\b__attribute__\s*\(\s*\(.*_*section_*\s*\(\s*("[^"]*")/) {
> > > > + my $old = substr($rawline, $-[1], $+[1] -
> > > > $-[1]);
> > > > + my $new = substr($old, 1, -1);
> > > > + WARN("PREFER_SECTION",
> > > > + "__section($new) is preferred over
> > > > __attribute__((section($old)))\n" . $herecurr);
> > > > + }
> > > > +
> > >
> > > I can't read Perl, but this looks pretty good.
> > > Acked-by: Nick Desaulniers <[email protected]>
> >
> > I'll add a Suggested-by: for you.
> >
> > But a Tested-by would be more valuable than an Acked-by if you
> > don't actually know how it works.
>
> $ git am joes.patch
> $ echo "int foo __attribute__((section(.hello)));" >> arch/x86/boot/a20.c
Does this compile?
checkpatch is not a compiler.
I think you need
__attribute__((section(".hello")))
> $ git commit arch/x86/boot/a20.c -sm "foo: bar\n baz"
> $ git format-patch HEAD~
> $ ./scripts/checkpatch.pl 0001-foo-bar.patch
> total: 0 errors, 0 warnings, 4 lines checked
>
> 0001-foo-bar.patch has no obvious style problems and is ready for submission.
>
> hmm...
