Hi, On 13/08/19 8:37 AM, Z.q. Hou wrote: > Hi Andrew, > > Thanks a lot for your comments! > >> -----Original Message----- >> From: Andrew Murray <[email protected]> >> Sent: 2019年8月12日 16:45 >> To: Z.q. Hou <[email protected]> >> Cc: [email protected]; [email protected]; >> [email protected]; [email protected]; >> [email protected]; [email protected]; [email protected]; >> [email protected]; [email protected]; Leo Li >> <[email protected]>; [email protected]; M.h. Lian >> <[email protected]>; Kishon Vijay Abraham I <[email protected]>; >> Gabriele Paoloni <[email protected]> >> Subject: Re: [PATCH 1/4] dt-bingings: PCI: Remove the num-lanes from >> Required properties >> >> On Mon, Aug 12, 2019 at 04:22:16AM +0000, Z.q. Hou wrote: >>> From: Hou Zhiqiang <[email protected]> >>> >>> The num-lanes is not a mandatory property, e.g. on FSL Layerscape >>> SoCs, the PCIe link training is completed automatically base on the >>> selected SerDes protocol, it doesn't need the num-lanes to set-up the >>> link width. >>> >>> It has been added in the Optional properties. This patch is to remove >>> it from the Required properties. >> >> For clarity, maybe this paragraph can be reworded to: >> >> "It is previously in both Required and Optional properties, let's remove it >> from the Required properties". > > Agree and will change in v2. > >> >> I don't understand why this property is previously in both required and >> optional... >> >> It looks like num-lanes was first made optional back in >> 2015 and removed from the Required section (907fce090253). >> But then re-added back into the Required section in 2017 with the adition of >> bindings for EP mode (b12befecd7de). >> >> Is num-lanes actually required for EP mode? > > Kishon, please help to answer this query?
It should be optional for EP too. Thanks Kishon
