Implement .alarm_irq_enable so it is possible to use RTC_ALM_SET,
RTC_AIE_ON and RTC_AIE_OFF.

Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com>
---
 drivers/rtc/rtc-pcf2123.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c
index 26f43b619b48..bda4b1687318 100644
--- a/drivers/rtc/rtc-pcf2123.c
+++ b/drivers/rtc/rtc-pcf2123.c
@@ -236,6 +236,14 @@ static int pcf2123_rtc_set_time(struct device *dev, struct 
rtc_time *tm)
        return 0;
 }
 
+static int pcf2123_rtc_alarm_irq_enable(struct device *dev, unsigned int en)
+{
+       struct pcf2123_data *pcf2123 = dev_get_drvdata(dev);
+
+       return regmap_update_bits(pcf2123->map, PCF2123_REG_CTRL2, CTRL2_AIE,
+                                 en ? CTRL2_AIE : 0);
+}
+
 static int pcf2123_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alm)
 {
        struct pcf2123_data *pcf2123 = dev_get_drvdata(dev);
@@ -293,15 +301,7 @@ static int pcf2123_rtc_set_alarm(struct device *dev, 
struct rtc_wkalrm *alm)
        if (ret)
                return ret;
 
-       /* Enable alarm interrupt */
-       if (alm->enabled)       {
-               ret = regmap_update_bits(pcf2123->map, PCF2123_REG_CTRL2,
-                                               CTRL2_AIE, CTRL2_AIE);
-               if (ret)
-                       return ret;
-       }
-
-       return 0;
+       return pcf2123_rtc_alarm_irq_enable(dev, alm->enabled);
 }
 
 static irqreturn_t pcf2123_rtc_irq(int irq, void *dev)
@@ -370,6 +370,7 @@ static const struct rtc_class_ops pcf2123_rtc_ops = {
        .set_offset     = pcf2123_set_offset,
        .read_alarm     = pcf2123_rtc_read_alarm,
        .set_alarm      = pcf2123_rtc_set_alarm,
+       .alarm_irq_enable = pcf2123_rtc_alarm_irq_enable,
 };
 
 static int pcf2123_probe(struct spi_device *spi)
-- 
2.21.0

Reply via email to