Acked-by: Karan Tilak Kumar <[email protected]> -----Original Message----- From: Colin King <[email protected]> Sent: Tuesday, August 13, 2019 6:24 AM To: Satish Kharat (satishkh) <[email protected]>; Sesidhar Baddela (sebaddel) <[email protected]>; Karan Tilak Kumar (kartilak) <[email protected]>; James E . J . Bottomley <[email protected]>; Martin K . Petersen <[email protected]>; [email protected] Cc: [email protected]; [email protected] Subject: [PATCH] scsi: fnic: remove redundant assignment of variable rc
From: Colin Ian King <[email protected]> Variable ret is initialized to a value that is never read and it is re-assigned later and immediatetly returns. Clean up the code by removing rc and just returning 0. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King <[email protected]> --- drivers/scsi/fnic/fnic_debugfs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/fnic/fnic_debugfs.c b/drivers/scsi/fnic/fnic_debugfs.c index 21991c99db7c..13f7d88d6e57 100644 --- a/drivers/scsi/fnic/fnic_debugfs.c +++ b/drivers/scsi/fnic/fnic_debugfs.c @@ -52,7 +52,6 @@ static struct fc_trace_flag_type *fc_trc_flag; */ int fnic_debugfs_init(void) { - int rc = -1; fnic_trace_debugfs_root = debugfs_create_dir("fnic", NULL); fnic_stats_debugfs_root = debugfs_create_dir("statistics", @@ -70,8 +69,7 @@ int fnic_debugfs_init(void) fc_trc_flag->fc_clear = 4; } - rc = 0; - return rc; + return 0; } /* -- 2.20.1
