On Thu, Aug 15, 2019 at 3:34 PM David Miller <da...@davemloft.net> wrote: > > From: Wenwen Wang <wen...@cs.uga.edu> > Date: Tue, 13 Aug 2019 20:33:45 -0500 > > > In pch_gbe_set_ringparam(), if netif_running() returns false, 'tx_old' and > > 'rx_old' are not deallocated, leading to memory leaks. To fix this issue, > > move the free statements after the if branch. > > > > Signed-off-by: Wenwen Wang <wen...@cs.uga.edu> > > Why would they be "deallocated"? They are still assigned to > adapter->tx_ring and adapter->rx_ring.
'adapter->tx_ring' and 'adapter->rx_ring' has been covered by newly allocated 'txdr' and 'rxdr' respectively before this if statement. Wenwen
