On Fri, Aug 16, 2019 at 10:13:38PM +0200, Pavel Machek wrote: > Hi! > > Please Cc led mailing lists on led issues.
sorry for missing this > On Tue 2019-08-13 12:11:44, Matthias Kaehlcke wrote: > > The LED behavior of some Ethernet PHYs is configurable. Add an > > optional 'leds' subnode with a child node for each LED to be > > configured. The binding aims to be compatible with the common > > LED binding (see devicetree/bindings/leds/common.txt). > > > > A LED can be configured to be: > > > > - 'on' when a link is active, some PHYs allow configuration for > > certain link speeds > > speeds > > - 'off' > > - blink on RX/TX activity, some PHYs allow configuration for > > certain link speeds > > > > For the configuration to be effective it needs to be supported by > > the hardware and the corresponding PHY driver. > > > > Suggested-by: Andrew Lunn <[email protected]> > > Signed-off-by: Matthias Kaehlcke <[email protected]> > > > @@ -173,5 +217,20 @@ examples: > > reset-gpios = <&gpio1 4 1>; > > reset-assert-us = <1000>; > > reset-deassert-us = <2000>; > > + > > + leds { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + led@0 { > > + reg = <0>; > > + linux,default-trigger = "phy-link-1g"; > > + }; > > Because this affects us. > > Is the LED software controllable? it might be for certain PHYs, integration with the LED framework is not part of this series. > Or can it do limited subset of triggers you listed? it depends on the PHY. The one in this series (RTL8211E) only supports a limited subset of the listed triggers.
